summaryrefslogtreecommitdiff
path: root/module_sigrokdecode.c
diff options
context:
space:
mode:
authorUwe Hermann <uwe@hermann-uwe.de>2017-06-28 22:29:06 +0200
committerUwe Hermann <uwe@hermann-uwe.de>2017-06-30 13:05:09 +0200
commit514b2edc54efda9c6698456748c4256bb901eddd (patch)
tree3a46086d63e37dec48fa0acedaa204513abb44ec /module_sigrokdecode.c
parentc1495906011ebabf97e799fe0f73e68ab0f1611a (diff)
downloadlibsigrokdecode-514b2edc54efda9c6698456748c4256bb901eddd.tar.gz
libsigrokdecode-514b2edc54efda9c6698456748c4256bb901eddd.zip
Acquire/release the Python GIL where needed to avoid threading issues.
With these additions, frontends can now call libsigrokdecode API functions from different threads without running into threading issues. The backend releases the GIL when it is performing tasks that might take a while and it doesn't need to run Python/C API calls during that time. This allows frontends to run multiple PD stacks (in multiple frontend threads) "at the same time" in a time-sharing, "interlocked" manner. Whenever one of the decoders is inside e.g. self.wait() it releases the GIL and thus allows other decoders to do some work in the mean time. The user-visible effect is that for use-cases such as running 3 different decoder stacks at the same time for an acquisition, the user will not have to wait for PD 1 to finish decoding, then wait for PD 2 to finish decoding, and only *then* being able to see annotations from PD 3. Instead, all three PDs will decode some chunks of data from time to time, thus the user is able to inspect annotations from all 3 PDs while the acquisition and decoding is still going on.
Diffstat (limited to 'module_sigrokdecode.c')
-rw-r--r--module_sigrokdecode.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/module_sigrokdecode.c b/module_sigrokdecode.c
index a0d9610..ab5df19 100644
--- a/module_sigrokdecode.c
+++ b/module_sigrokdecode.c
@@ -42,6 +42,9 @@ static struct PyModuleDef sigrokdecode_module = {
PyMODINIT_FUNC PyInit_sigrokdecode(void)
{
PyObject *mod, *Decoder_type;
+ PyGILState_STATE gstate;
+
+ gstate = PyGILState_Ensure();
mod = PyModule_Create(&sigrokdecode_module);
if (!mod)
@@ -68,10 +71,13 @@ PyMODINIT_FUNC PyInit_sigrokdecode(void)
mod_sigrokdecode = mod;
+ PyGILState_Release(gstate);
+
return mod;
err_out:
Py_XDECREF(mod);
srd_exception_catch("Failed to initialize module");
+ PyGILState_Release(gstate);
return NULL;
}