diff options
author | Gerhard Sittig <gerhard.sittig@gmx.net> | 2020-07-27 21:58:55 +0200 |
---|---|---|
committer | Gerhard Sittig <gerhard.sittig@gmx.net> | 2020-08-30 07:23:58 +0200 |
commit | 80c76d2092814d2cd7d0f9fc6ddd6c0c937106dc (patch) | |
tree | 45f3c1da04177c95f237a642a7727fcb7b19328c /decoders/common/srdhelper | |
parent | c328c18123c83e0f1e54181b9634bec76a2e3c43 (diff) | |
download | libsigrokdecode-80c76d2092814d2cd7d0f9fc6ddd6c0c937106dc.tar.gz libsigrokdecode-80c76d2092814d2cd7d0f9fc6ddd6c0c937106dc.zip |
sle44xx: rework data bits accumulation, and byte presentation
The 'databyte' is strictly local to the routine when 8 bits were seen.
The 'bitcount' is redundant and becomes obsolete when bits[] is a Python
list. The comment and the code disagreed, the wire is said to communicate
bits in LSB first order, the implemenation kept accumulating bits in the
reverse order (the annotation part, not the data byte math). Prefer the
common helper to convert bits to bytes.
There is uncertainty about the bit width "estimation" logic. The main
loop's .wait() conditions suggest that data bit values are valid for the
period of high CLK, which provides an easier and more robust condition
for annotation boundaries. Add a comment for now. The order of bit and
byte values' annotation emission is unfortunate, too.
Diffstat (limited to 'decoders/common/srdhelper')
0 files changed, 0 insertions, 0 deletions