diff options
| author | Gerhard Sittig <gerhard.sittig@gmx.net> | 2022-12-30 14:09:03 +0100 |
|---|---|---|
| committer | Gerhard Sittig <gerhard.sittig@gmx.net> | 2023-01-09 20:13:35 +0100 |
| commit | 317eaa7fd83fb049db97e863a306992a34fcf490 (patch) | |
| tree | 0e80e1dd1731cb4fe524e63a9368612d01607750 | |
| parent | adb8233a0bf30b1d9ee9176e1caa5dc8ae1830dd (diff) | |
| download | libsigrokdecode-317eaa7fd83fb049db97e863a306992a34fcf490.tar.gz libsigrokdecode-317eaa7fd83fb049db97e863a306992a34fcf490.zip | |
adf435x: use common bits to number conversion helper
Use common support code to convert bit fields to integer numbers. Also
unobfuscate the decode_bits() method and its returned values' layout.
Improves readability and factors out common expressions.
| -rw-r--r-- | decoders/adf435x/pd.py | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/decoders/adf435x/pd.py b/decoders/adf435x/pd.py index 9ba88ca..8c31648 100644 --- a/decoders/adf435x/pd.py +++ b/decoders/adf435x/pd.py @@ -18,6 +18,7 @@ ## import sigrokdecode as srd +from common.srdhelper import bitpack_lsb def disabled_enabled(v): return ['Disabled', 'Enabled'][v] @@ -118,8 +119,10 @@ class Decoder(srd.Decoder): self.out_ann = self.register(srd.OUTPUT_ANN) def decode_bits(self, offset, width): - return (sum([(1 << i) if self.bits[offset + i][0] else 0 for i in range(width)]), - (self.bits[offset + width - 1][1], self.bits[offset][2])) + bits = self.bits[offset:][:width] + ss, es = bits[-1][1], bits[0][2] + value = bitpack_lsb(bits, 0) + return ( value, ( ss, es, )) def decode_field(self, name, offset, width, parser): val, pos = self.decode_bits(offset, width) |