summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorUwe Hermann <uwe@hermann-uwe.de>2018-05-16 00:21:56 +0200
committerUwe Hermann <uwe@hermann-uwe.de>2018-05-16 12:17:42 +0200
commit2d661bcb259dedee1857e90749418ce72f571ba6 (patch)
treef8db6bc6e2d25ee2a8101ebd88b59905400cb8ab
parent60d4764a9c699d0b4aca656831a4d8d09568b659 (diff)
downloadlibsigrokdecode-2d661bcb259dedee1857e90749418ce72f571ba6.tar.gz
libsigrokdecode-2d661bcb259dedee1857e90749418ce72f571ba6.zip
decoder.c: Fix a scan-build warning.
decoder.c:343:9: warning: Access to field 'ob_type' results in a dereference of a null pointer (loaded from variable 'py_default') if (Py_TYPE(py_default) != Py_TYPE(py_item)) { ^~~~~~~~~~~~~~~~~~~ /usr/include/python3.6m/object.h:118:33: note: expanded from macro 'Py_TYPE' #define Py_TYPE(ob) (((PyObject*)(ob))->ob_type) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
-rw-r--r--decoder.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/decoder.c b/decoder.c
index 21b756b..bebe96c 100644
--- a/decoder.c
+++ b/decoder.c
@@ -340,7 +340,7 @@ static int get_options(struct srd_decoder *d)
if (!py_item)
goto except_out;
- if (Py_TYPE(py_default) != Py_TYPE(py_item)) {
+ if (py_default && (Py_TYPE(py_default) != Py_TYPE(py_item))) {
srd_err("All values for option '%s' must be "
"of the same type as the default.",
o->id);