From e4f70391abbb153364a534d45a59026961ce1b1f Mon Sep 17 00:00:00 2001 From: Gerhard Sittig Date: Tue, 18 Aug 2020 21:05:17 +0200 Subject: sle44xx: minor developer comment and style nits These are just nits, behaviour remains. The comment may be incorrect how command and data modes are detected. Add a developer comment for later revisit. Drop unneeded parentheses in a ternary operation, and move an ATR related comment around. --- decoders/sle44xx/pd.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'decoders') diff --git a/decoders/sle44xx/pd.py b/decoders/sle44xx/pd.py index f84bea6..775ee3c 100644 --- a/decoders/sle44xx/pd.py +++ b/decoders/sle44xx/pd.py @@ -105,14 +105,16 @@ class Decoder(srd.Decoder): cls, texts = lookup_proto_ann_txt(self.cmd, {}) self.putx([cls, texts]) self.bits = [] - self.cmd = 'ATR' # Next data bytes will be ATR + # Next data bytes will be Answer To Reset. + self.cmd = 'ATR' def handle_command(self, pins): rst, clk, io = pins self.ss, self.es = self.samplenum, self.samplenum + # XXX Is the comment inverted? # If I/O is rising -> command START # if I/O is falling -> command STOP and response data incoming - self.cmd = 'CMD' if (io == 0) else 'DATA' + self.cmd = 'CMD' if io == 0 else 'DATA' self.bits = [] # Gather 8 bits of data -- cgit v1.2.3-70-g09d2