From 1e9dfe605f11ce2535a740e20555bbc439c0fc1a Mon Sep 17 00:00:00 2001 From: Uwe Hermann Date: Sat, 11 Jan 2020 00:17:44 +0100 Subject: sdcard_sd: Remove a list that needs manual maintenance. Instead of checking if a command is in a fixed list/tuple (that needs to be manually updated every time a new command becomes supported), simply check if the respective handling method for the command exists. This fixes the bug of the CMD16 handler not being called, and will prevent similar bugs in the future. --- decoders/sdcard_sd/pd.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'decoders/sdcard_sd') diff --git a/decoders/sdcard_sd/pd.py b/decoders/sdcard_sd/pd.py index b6a076b..32a25ae 100644 --- a/decoders/sdcard_sd/pd.py +++ b/decoders/sdcard_sd/pd.py @@ -181,7 +181,7 @@ class Decoder(srd.Decoder): # Handle command. s = 'ACMD' if self.is_acmd else 'CMD' self.cmd_str = '%s%d (%s)' % (s, self.cmd, self.cmd_name(self.cmd)) - if self.cmd in (0, 2, 3, 6, 7, 8, 9, 10, 13, 41, 51, 55): + if hasattr(self, 'handle_%s%d' % (s.lower(), self.cmd)): self.state = St['HANDLE_CMD%d' % self.cmd] else: self.state = St.HANDLE_CMD999 -- cgit v1.2.3-70-g09d2