From 8ad9a3e48ddf79e08cd48073c953ea665c464005 Mon Sep 17 00:00:00 2001 From: Uwe Hermann Date: Wed, 16 May 2018 01:27:30 +0200 Subject: type_decoder.c: Fix a memory leak reported by scan-build. type_decoder.c:206:2: warning: Potential leak of memory pointed to by 'pdb' PyGILState_Release(gstate); ^~~~~~~~~~~~~~~~~~ --- type_decoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/type_decoder.c b/type_decoder.c index dfa3fa9..35187a5 100644 --- a/type_decoder.c +++ b/type_decoder.c @@ -186,12 +186,12 @@ static int convert_binary(struct srd_decoder_inst *di, PyObject *obj, goto err; } - pdb = g_malloc(sizeof(struct srd_proto_data_binary)); if (PyBytes_AsStringAndSize(py_tmp, &buf, &size) == -1) goto err; PyGILState_Release(gstate); + pdb = g_malloc(sizeof(struct srd_proto_data_binary)); pdb->bin_class = bin_class; pdb->size = size; if (!(pdb->data = g_try_malloc(pdb->size))) { -- cgit v1.2.3-70-g09d2