summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-01-29DS1307: Bugs fixes.Libor Gabaj
- Square wave frequencies above 1 Hz are in Hz not in kHz. - AM/PM flag is in the bit 5 of hours register not in bit 6. - AM flag is valid at 0 value of AM/PM flag not at 1 value.
2018-11-25uart: remove obsolete TODO (Python annotation for frame errors)Gerhard Sittig
The "Frame error?" TODO comment on Python annotations has become obsolete. Individual bit errors within the frame immediately get communicated as they are detected (START, parity, STOP). The overall frame's validity has become available with the FRAME annotation.
2018-11-25uart: add FRAME Python annotation, communicate frame validityGerhard Sittig
Internally keep track of the UART frame's validity. Emit a FRAME Python annotation for aborted as well as for completed frames. This obsoletes a TODO comment in the STOP bit code path. This annotation also spans the complete frame's length, including start and parity and stop bits, which the DATA annotation doesn't cover. Stacked decoders can individually decide whether to strictly reference the mere data bits section or the complete UART frame which happened to communicate the data value.
2018-11-25uart: document the Python annotation for BREAKGerhard Sittig
2018-11-20i2s: Fix 2 issues.Weixiao Zhang
1. WS = 0, Left Channel; WS = 1, Right Channel 2. Data start and end at falling edge of SCK
2018-11-10x2444m: Add some shorter annotation strings as well.Uwe Hermann
2018-11-10x2444m: Move variable initializations to reset().Uwe Hermann
2018-11-10x2444m: Make each command an extra annotation class.Uwe Hermann
2018-11-09Decoder for Xicor X2444M, nonvolatile static RAM.Stefan Petersen
2018-10-21decoder: consider reset() a mandatory decoder methodGerhard Sittig
In theory support for PD reset is optional, applications are not required to make use of it. But it's essential to receive correct decoding results when used with the popular Pulseview mainline application. So let's consider the absence of the reset() method fatal. All mainline decoders have it. Out-of-tree decoders are easy to adjust, and very probably should support reset() as well. Thus this change is considered beneficial, and not harmful.
2018-10-21miller: add reset() methodGerhard Sittig
2018-10-21lin: Simplify state handling a bit.Uwe Hermann
2018-10-21lin: handle_break(): Use self.putx().Uwe Hermann
2018-10-21lin: Simplify LinFsm._transition_allowed().Uwe Hermann
2018-10-21add LIN protocol decoderstephan.thiele
2018-10-21spiflash: Remember write protection latch from status registersVesa-Pekka Palmu
2018-10-21spiflash: Bugfix: WRSR was using miso for register decodeVesa-Pekka Palmu
2018-10-21spiflash: Initial support for write enable state trackingVesa-Pekka Palmu
2018-10-21spiflash: Handle chip eraseVesa-Pekka Palmu
Minimal implementation of chip erase 0x60 and 0xc7 command handling
2018-10-21spiflash: Add Winbond W25Q80DV metadata.Uwe Hermann
2018-10-21Fix GVariant memory leaks in session test codeJon Burgess
==187759== 88 (40 direct, 48 indirect) bytes in 1 blocks are definitely lost in loss record 2,262 of 3,218 ==187759== at 0x4C2EBAB: malloc (vg_replace_malloc.c:299) ==187759== by 0x563C435: g_malloc (in /usr/lib64/libglib-2.0.so.0.5600.3) ==187759== by 0x5654056: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.5600.3) ==187759== by 0x5673630: g_variant_new_from_bytes (in /usr/lib64/libglib-2.0.so.0.5600.3) ==187759== by 0x566C5E6: ??? (in /usr/lib64/libglib-2.0.so.0.5600.3) ==187759== by 0x566C7D2: g_variant_new_uint64 (in /usr/lib64/libglib-2.0.so.0.5600.3) ==187759== by 0x403D41: conf_check_fail.constprop.6 (session.c:152) ==187759== by 0x403E06: test_session_metadata_set_bogus (session.c:215) ==187759== by 0x53E51D5: srunner_run_tagged (in /usr/lib64/libcheck.so.0.0.0) ==187759== by 0x401237: main (main.c:51)
2018-10-21Fix memory leak in decoder test codeJon Burgess
==187724== 917 bytes in 1 blocks are definitely lost in loss record 3,046 of 3,207 ==187724== at 0x4C2EBAB: malloc (vg_replace_malloc.c:299) ==187724== by 0x563C435: g_malloc (in /usr/lib64/libglib-2.0.so.0.5600.3) ==187724== by 0x5655D82: g_strdup (in /usr/lib64/libglib-2.0.so.0.5600.3) ==187724== by 0x4E43937: py_str_as_str (util.c:371) ==187724== by 0x4E415E1: srd_decoder_doc_get (decoder.c:892) ==187724== by 0x40281D: test_doc_get (decoder.c:395) ==187724== by 0x53E51D5: srunner_run_tagged (in /usr/lib64/libcheck.so.0.0.0) ==187724== by 0x401237: main (main.c:51)
2018-10-21Fix memory leak in print_searchpaths()Jon Burgess
==175453== 522 bytes in 8 blocks are definitely lost in loss record 2,923 of 3,201 ==175453== at 0x4C2EBAB: malloc (vg_replace_malloc.c:299) ==175453== by 0x59E9BB5: PyObject_Malloc (in /usr/lib64/libpython3.6m.so.1.0) ==175453== by 0x5A35A76: PyBytes_FromStringAndSize (in /usr/lib64/libpython3.6m.so.1.0) ==175453== by 0x4E3FA6E: print_searchpaths (srd.c:173) ==175453== by 0x4E3FA6E: srd_init (srd.c:287) ==175453== by 0x4034BE: test_session_reset_nodata (session.c:238) ==175453== by 0x53E51D5: srunner_run_tagged (in /usr/lib64/libcheck.so.0.0.0) ==175453== by 0x401237: main (main.c:51)
2018-10-21Fix bad memory accesses during srd_exit()Jon Burgess
When the decoder and session unload functions are called they remove themselves from the list. The code walking the list must be careful to avoid accessing the next pointer which might now be invalid. The g_slist_foreach() takes care of this. Reports from Valgrind before fix: ==175436== Invalid read of size 8 -- ==175436== Address 0xe3f2598 is 8 bytes inside a block of size 16 free'd ==175436== at 0x4C2FDAC: free (vg_replace_malloc.c:530) ==175436== by 0x563C541: g_free (in /usr/lib64/libglib-2.0.so.0.5600.3) ==175436== by 0x5654783: g_slice_free1 (in /usr/lib64/libglib-2.0.so.0.5600.3) ==175436== by 0x56552A2: g_slist_remove (in /usr/lib64/libglib-2.0.so.0.5600.3) ==175436== by 0x4E3FEFF: srd_session_destroy (session.c:343) ==175436== by 0x4E3F5C7: srd_exit (srd.c:311) ==175436== by 0x40336F: test_inst_new (inst.c:40) ==175436== by 0x53E51D5: srunner_run_tagged (in /usr/lib64/libcheck.so.0.0.0) ==175436== by 0x401237: main (main.c:51) ==175436== Block was alloc'd at ==175436== at 0x4C2EBAB: malloc (vg_replace_malloc.c:299) ==175436== by 0x563C435: g_malloc (in /usr/lib64/libglib-2.0.so.0.5600.3) ==175436== by 0x5654056: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.5600.3) ==175436== by 0x5655797: g_slist_append (in /usr/lib64/libglib-2.0.so.0.5600.3) ==175436== by 0x4E3FC75: srd_session_new (session.c:71) ==175436== by 0x403345: test_inst_new (inst.c:37) ==175436== by 0x53E51D5: srunner_run_tagged (in /usr/lib64/libcheck.so.0.0.0) ==175436== by 0x401237: main (main.c:51)
2018-10-16Update a few Doxygen @since tags.Uwe Hermann
Drop @since tags for non-public functions.
2018-10-16instance.c: Avoid 4 unneeded forward declarations.Uwe Hermann
2018-10-16uart: add support for break condition detectionGerhard Sittig
There are the "traffic inspecting" wait() conditions, which check an edge to find the start of START, then wait for sample points to grab the bit values. Bit times are sampled in their respective center, potential glitches around sample points get ignored. Add another independent set of wait() conditions which check _all_ edges regardless of any data communication. This results in the most reliable and maintainable detection of break conditions, regardless of how they align to data frames. Break is defined as a period of low input signal which spans at least one frame's length. Run the edge inspection after data inspection, which results in the most appropriate annotation output like leading data bits (of incomplete frames), frame errors (violated STOP bit expectations), then break conditions. This approach is most robust in the presence of incomplete input streams.
2018-10-13ook: Fix two typos which affect the decoding results.Uwe Hermann
2018-10-13Various log message improvements.Uwe Hermann
2018-10-13log: Use human-readable output type name everywhere.Uwe Hermann
2018-10-13instance.c: Make oldpins_array_*() static.Uwe Hermann
2018-10-13Decoder_put(): Add more info to OTUPUT_PYTHON log messages.Uwe Hermann
2018-10-06srd.c: Fix a compiler warning with gcc 8.Uwe Hermann
srd.c: In function ‘srd_searchpaths_get’: srd.c:399:40: warning: cast between incompatible function types from ‘gchar * (*)(const gchar *)’ {aka ‘char * (*)(const char *)’} to ‘void * (*)(const void *, void *)’ [-Wcast-function-type] return g_slist_copy_deep(searchpaths, (GCopyFunc)g_strdup, NULL); ^ Upstream glib issue / documentation change: https://gitlab.gnome.org/GNOME/glib/issues/1492 https://gitlab.gnome.org/pwithnall/glib/commit/e81f4c2acea5ada6ae989426e462613f7c612cac
2018-10-06type_decoder.c: Fix trailing whitespace.Uwe Hermann
2018-09-12morse: fix for #1278Christoph Rackwitz
2018-09-11ook_vis: Minor code simplifications.Uwe Hermann
2018-09-11ook_oregon: Minor code simplifications.Uwe Hermann
2018-09-11ook: Minor code simplifications.Uwe Hermann
2018-09-11added ook_visSteve R
2018-09-11added ook_oregonSteve R
2018-09-11added ookSteve R
2018-09-10miller: Minor description/whitespace fixes.Uwe Hermann
2018-09-10atsha204a: Add missing full stop in description.Uwe Hermann
2018-09-09miller: Add missing 'binary' meta-data.Uwe Hermann
2018-09-09Miller encoding PDChristoph Rackwitz
2018-09-09cec: Drop uneeded self.set_stat().Uwe Hermann
2018-09-09cec: Replace unneeded decode_opcode().Uwe Hermann
2018-09-09cec: Simplify a few code snippets.Uwe Hermann
2018-09-09Add HDMI CEC protocol decoder.Jorge Solla
2018-09-09usb_power_delivery: Whitespace/consistency cosmetics.Uwe Hermann
All annotation classes/rows have all-lowercase IDs. Also fix a few minor whitespace/consistency issues.