Age | Commit message (Collapse) | Author |
|
This will allow for usage of different colors in UIs, and for
showing/hiding them independently in UIs.
|
|
This also fixes the CURRENT_STATE and RSVD_TESTMODE fields, which are
not single-bit fields.
|
|
|
|
|
|
The responses were simply named "R1" etc., but this becomes inconvenient
when Ann.prefixeѕ('R') is used and other annotation classes also have
names that start with 'R'. Hence, rename respose annotation classes to
"RESPONSE_R1" etc.
|
|
Usually we'd use namedtuple(), but in this case we need to
retro-actively modify the items, so that's not possible.
|
|
|
|
Differentiate cmd (e.g. 55 or CMD55) vs. cmd_pin (the value of the CMD pin).
|
|
Instead of checking if a command is in a fixed list/tuple (that needs
to be manually updated every time a new command becomes supported),
simply check if the respective handling method for the command exists.
This fixes the bug of the CMD16 handler not being called, and will
prevent similar bugs in the future.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Also, rename "reply" to "response" to use the wording from the spec.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Also, automate construction of the Ann SrdIntEnum.
This avoids having to remember to manually keep two lists in sync.
|
|
|
|
This also fixes incorrect annotation classes for bit, bit warning, and R1.
Also, auto-generate some more parts of the annotation class listing.
|
|
|
|
|
|
|
|
Also, automate construction of the Ann SrdIntEnum.
This avoids having to remember to manually keep two lists in sync.
|
|
|
|
|
|
|
|
|
|
|
|
cJTAG only has two wires/channels.
|
|
|
|
|
|
|
|
|
|
[Note: This is a commit from Kongou Hikari ("diodep" on GitHub) that was
"rebased" by Uwe Hermann on top of the current libsigrokdecode mainline JTAG
decoder. There are various reasons for this, including avoiding non-mainline
or outdated decoder changes, as well as making it easily visible what the
changes vs. the current JTAG decoder are, in case we later need to apply some
changes to both decoders or in case both decoders might be merged later on.
Minor cosmetic and naming changes were also squashed in (no functional
changes, though).]
|
|
|
|
This is not technically a bug since (at least some) datasheets refer
to this command as "Chip erase", it just happens to have two different
command codes (0x60 and 0xc7).
In order to not confuse users with two annotation classes with the
same name, we'll call the second one "Chip erase 2" to match the
"CE2" short name.
This fixes bug #1482.
|
|
It was unfortunate that the previous DMX512 decoder implementation
re-invented UART decoder features and introduced new issues in the
process. Automatic polarity detection is just impossible when the full
set of valid DMX timings is to get supported. Sample numbers suffered
from floating point rounding errors.
Introduce a stacked decoder on top of UART which exclusively deals with
DMX512 details, and transparently benefits from all available UART
features (adjustable polarity, robust and correct sampling, data byte
accumulation, BREAK detection while silencing false STOP violations). On
one hand this requires users to specify the bitrate (250kbps), on the
other hand it results in reliable operation for all captures that have
become available so far.
Provide Python output for stacked decoders which can process protocol
extensions like RDM. Prepare the DMX512 decoder itself to handle simple
cases of protocol extensions (start codes other than 0). Add support for
additional constraint checks, emit warnings when user specified limits
are violated: short BREAK, long MARK, long RESET to RESET and short
BREAK to BREAK intervals. This shall speedup the identification of bus
health issues (data loss or corruption) or improper controller timing.
Also hide all-zero values by default, to make used channels visually
stand out, and help users focus their attention. For special cases (like
16bit data, or zero being a valid set-point for the channels) users can
enforce the display of all values. Provide an option to present byte
values to users in the most appropriate format for the use case.
This resolves bug #1442.
|
|
The existing DMX512 decoder implementation duplicates UART specific
knowledge, and implements some of the redundant logic in ways which fail
to interpret correct input data. See bug #1442 for details.
This commit removes the previous decoder implementation before adding a
more recent version, to gain a more readable history across that decoder
replacement.
|